Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Waveform Minibar (mod) (Read 153890 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: Waveform Minibar (mod)

Reply #475 –
Quote from: Case on
I expect Peter to fix it for a future version.

I never expected an issue to be resolved this fast, thank you for (what I assume happened) forwarding my issue towards someone who could, and was able to fix it!

Re: Waveform Minibar (mod)

Reply #476 –
Hello developper.

I'd love to have a stereo view of this addon. For me, it's an absolute deal breaker because it helps me viualize my music and mono downsampling does not fulfill this need. This is the reason why I've stuck with the ressource intensive OG Waveform Seekbar.

Re: Waveform Minibar (mod)

Reply #477 –
Is there a chance for a Mac version of this plugin?

Re: Waveform Minibar (mod)

Reply #478 –
Wait, there's still no stereo and surround modes? Having it in mono only is useless!

Re: Waveform Minibar (mod)

Reply #479 –
I've been using it every day since it was released, with much pleasure, so definitely not useless for me, and many others I am guessing. I have it so thin that a stereo mode would be useless (for me) as it would show so little information.

Re: Waveform Minibar (mod)

Reply #480 –
Quote from: darkflame23 on
I've been using it every day since it was released, with much pleasure, so definitely not useless for me, and many others I am guessing. I have it so thin that a stereo mode would be useless (for me) as it would show so little information.
Exactly.

The minibar serves a different purpose.
No one stops you to open the original waveseekbar (too) to see more details (for instance with multichannel).

Re: Waveform Minibar (mod)

Reply #481 –
I've been noticing some blocking interactions between this component, the built-in oscilloscope and foo_midi/foo_vis_midi when playing MIDI files. Unless minibar processing is "halted," the oscilloscope freezes and foo_vis_midi displays wildly incorrect notes or nothing at all. Especially when no waveforms are stored and when the processing is on, MIDI waveform generation is hit-or-miss. Music playback is unaffected.

In contrast, playing XM files through foo_openmpt54 and its note visualization, the waveform renders quickly and exactly as expected. Same with foo_input_gme, which is why it's easy to single out the MIDI components (as opposed to all synthesized music).

Re: Waveform Minibar (mod)

Reply #482 –
Quote from: oops on
I've been noticing some blocking interactions between this component, the built-in oscilloscope and foo_midi/foo_vis_midi when playing MIDI files. Unless minibar processing is "halted," the oscilloscope freezes and foo_vis_midi displays wildly incorrect notes or nothing at all. Especially when no waveforms are stored and when the processing is on, MIDI waveform generation is hit-or-miss. Music playback is unaffected.

In contrast, playing XM files through foo_openmpt54 and its note visualization, the waveform renders quickly and exactly as expected. Same with foo_input_gme, which is why it's easy to single out the MIDI components (as opposed to all synthesized music).
foo_midi contains no graphics rendering code. What happens when you remove foo_vis_midi from the setup?

Re: Waveform Minibar (mod)

Reply #483 –
Quote from: pqyt on
foo_midi contains no graphics rendering code. What happens when you remove foo_vis_midi from the setup?
Unfortunately, it happens on a fresh portable install with just the oscilloscope and minibar (and foo_midi). Still the oscilloscope at the very least stutters at the start; sometimes just looks like it is paused especially during minibar processing. Even then, the minibar waveform might generate nothing or something uncorrelated to the actual track.

I tried all MIDI players with the same side effects on each: Emu, BASS, Munt, LibADL, LibOPN, NukeOPL3, VSTi, Secret Sauce; really looking forward to Nuked SC-55 by the way.

Launching into speculation here, but I do not think this is a foo_midi-specific issue. It just so happens that foo_midi does something (not sure what) that makes the problem very obvious and visible because as I mentioned in the previous post, playback is unaffected. Neither are other visualizations that rely on the eventual PCM data such as milk2, goom, vumeter, spectrum_analyzer. It might just simply be that whatever processing is happening in these MIDI libraries and the minibar is happening on the same thread and there is some thrashing.

For anyone running into this issue, the workaround to this is simply to select "Halt minibar processing" from the minibar context menu and live with just a basic seek bar for MIDI playback. So, I wouldn't classify this issue's impact or severity very high.

Thanks @pqyt for taking a look at this. Massive props and huge thanks for all your components!

Re: Waveform Minibar (mod)

Reply #484 –
@pqyt : hmm. It seems to me like foo_midi, at least with default settings, might have trouble with handling multiple decoding instances of the same track at once. I was trying to replicate the issues with oscilloscope and noticed that the waveform could stay blank, or if waveform is rendering the playback is silent. Or at times the output is simply completely incorrect.

Re: Waveform Minibar (mod)

Reply #485 –
Quote from: Case on
@pqyt : hmm. It seems to me like foo_midi, at least with default settings, might have trouble with handling multiple decoding instances of the same track at once. I was trying to replicate the issues with oscilloscope and noticed that the waveform could stay blank, or if waveform is rendering the playback is silent. Or at times the output is simply completely incorrect.
That's not exactly a common scenario and I certainly don't test for it. I'll check if any globals have been introduced (or maybe they were there from the start)

Could you advice on the minimal setup to replicate the scenario, please?

Re: Waveform Minibar (mod)

Reply #486 –
If you wish to code your own test tool, you could hook into playback callback and as soon as a track starts playing, open a custom decoder instance for the same track and just decode the track and check its output.
But to avoid coding a test tool, you can download waveform minibar and use it with its default settings.
Behavior seems to depend on midi files. I'll attach an example file that seems to replicate the issue here with 100% reliability.

Re: Waveform Minibar (mod)

Reply #487 –
Quote from: Case on
If you wish to code your own test tool, you could hook into playback callback and as soon as a track starts playing, open a custom decoder instance for the same track and just decode the track and check its output.
But to avoid coding a test tool, you can download waveform minibar and use it with its default settings.
Behavior seems to depend on midi files. I'll attach an example file that seems to replicate the issue here with 100% reliability.
Quote from: Case on
If you wish to code your own test tool, you could hook into playback callback and as soon as a track starts playing, open a custom decoder instance for the same track and just decode the track and check its output.
But to avoid coding a test tool, you can download waveform minibar and use it with its default settings.
Behavior seems to depend on midi files. I'll attach an example file that seems to replicate the issue here with 100% reliability.
Not sure what I'm looking for:
- Permadeath sounds like someone parking their derriere on the lower keys of a piano for 13min ;-)
- Waveform minibar (in a foo_flowin window) renders without a problem.
- Skipping back and forth in the file seems to update correctly,
- Switching tracks while playing re-renders the waveform and starts tracking the playback.

One exception: "The Simpsons.mid" renders nothing: not the preview and no tracking.

EDIT: Nah... The Simpsons works. The only weird behavior I detect is that sometimes a track refuses to play but switching back and forth 'fixes' that. Not sure where to start looking. Even VSTi's sometimes have the behavior.

Re: Waveform Minibar (mod)

Reply #488 –
The permadeath.mid was not chosen for its artistic merits. I just randomly picked tracks from Everything search "*.mid" from my computer trying to see the oscilloscope issue.

On my computer when playing the track and foo_midi manages to open it before Minibar, minibar gets nothing but silence from the track. There are zero errors, everything looks good, except foo_midi gives me nothing but zeroes. That's why I shared it, seems like an easy reproduction step.

If I change minibar to scan tracks on selection instead of after playback starts, selecting "The Simpsons.mid" or permadeath.mid and immediately also trying to play it can cause both the the minibar and playback all getting nothing but silence.

Note that minibar is not at fault here. It just happens to be a simple method to trigger two decoder instances for the same track simultaneously. Kode54's version of TAK decoder for example crashed every now and then in this test, main reason why I made my own TAK decoder.
You could get similar scenarios for example by playing a file and using converter for the same track at the exact same moment. Just harder to get the timing close, but not impossible.

Re: Waveform Minibar (mod)

Reply #489 –
Quote from: Case on
Note that minibar is not at fault here. It just happens to be a simple method to trigger two decoder instances for the same track simultaneously. Kode54's version of TAK decoder for example crashed every now and then in this test, main reason why I made my own TAK decoder.
You could get similar scenarios for example by playing a file and using converter for the same track at the exact same moment. Just harder to get the timing close, but not impossible.
I'm not looking to blame anything or anyone; it's an interesting bug hunt.

It could be a flaw in the original design but I have changed so much the last 2 years that it could easily be something introduced by the new code.

Re: Waveform Minibar (mod)

Reply #490 –
I have  posted about this issue here. With every release of foo_midi from v2.13.1 onwards, foo_wave_seekbar occasionally does not create a wave-image for a MIDI file. I have no such issues with foo_midi v2.12, which I have returned to ever since trying every new release of foo_midi.

Trying the recent v2.18.0.0 of foo_midi, the situation got worse. When playing a MIDI file, several of my preconfigured sound fonts don't get loaded, resulting in a very incomplete recreation of the MIDI file. Again, returning to foo_midi v2.12, I have no issues to report.