Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foobar2000 MP4 plugin (Read 11587 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

foobar2000 MP4 plugin

Hi,

I finished a first version of a mp4 input plugin for foobar2000. The code is in audiocoding.com CVS.

Menno

foobar2000 MP4 plugin

Reply #1 –
Compiled version for 0.32 temporarily here.

foobar2000 MP4 plugin

Reply #2 –
Nice.  I don't know if this is a problem with the plugin or the player, but when I load an mp4 with japanese characters, foobar crashes.  Any ideas?

foobar2000 MP4 plugin

Reply #3 –
Quote
Nice.  I don't know if this is a problem with the plugin or the player, but when I load an mp4 with japanese characters, foobar crashes.  Any ideas?

I think it's a plugin problem. The MP4 file reading library doesn't support unicode I guess.

Menno

foobar2000 MP4 plugin

Reply #5 –
is that with unicode characters in filenames or in tags ? mp4 decoder library should never touch filenames, it's all handled by fb2k itself.
Microsoft Windows: We can't script here, this is bat country.

foobar2000 MP4 plugin

Reply #6 –
Quote
is that with unicode characters in filenames or in tags ? mp4 decoder library should never touch filenames, it's all handled by fb2k itself.

Tags are not supported yet for MP4, I'll add that somewhere in January.
The MP4 file library does all the file operations and I don't feel like hacking it too much yet.

Divide by 0 picture doesn't really say much to me, unless Case used some very old code of faad2.

Menno

foobar2000 MP4 plugin

Reply #7 –
Quote
Tags are not supported yet for MP4, I'll add that somewhere in January.
The MP4 file library does all the file operations and I don't feel like hacking it too much yet.

Divide by 0 picture doesn't really say much to me, unless Case used some very old code of faad2.

Menno

that's not "hacking", your "plugin" is half-broken if it doesn't use file readers, and your libraries are useless if they don't support file access callbacks (i hope they do, too lazy to look at them).
i should make fb2k open files in no-share mode just to prevent people from doing what you just did.
<insert flame about libvorbis' superiority>
Microsoft Windows: We can't script here, this is bat country.

foobar2000 MP4 plugin

Reply #8 –
I don't use tags, the characters are only in filenames, if that helps.

foobar2000 MP4 plugin

Reply #9 –
oh, and tag updater "pretends to be working" by always returning 1 while it doesn't do anything. thats veeeery bad, it makes users think that they've edited tags on their files while they haven't.
Microsoft Windows: We can't script here, this is bat country.

foobar2000 MP4 plugin

Reply #10 –
I deleted foobar2000.cfg and the error disappeared.
Now foobar can load mp4 files with Japanese characters.

foobar2000 MP4 plugin

Reply #11 –
I'm using unmodified third party source code (Cisco) for reading mp4 files.

I'll change the set_info() return value. (writing some documentation for your API could help (or at least some comments in the code about the return values for each function)).

Menno

foobar2000 MP4 plugin

Reply #12 –
from input.h :
Quote
virtual int set_info(reader *r,const file_info * info) {return 0;};//reader with write access, return 0 on failure / not-our-file, 1 on success

am i seeing things ?
Microsoft Windows: We can't script here, this is bat country.

foobar2000 MP4 plugin

Reply #13 –
Quote
from input.h :
Quote
virtual int set_info(reader *r,const file_info * info) {return 0;};//reader with write access, return 0 on failure / not-our-file, 1 on success

am i seeing things ?

Aaargh 
I should try reading more than 80 characters per line

Menno

foobar2000 MP4 plugin

Reply #14 –
Quote
i should make fb2k open files in no-share mode just to prevent people from doing what you just did.

actually, a way to bypass file reader would be very useful in some cases. I mean when there's no file actually, like 'linein://' or 'cda://'. it was easy to handle in winamp2, but in foobar it requires stupid-looking hack.

foobar2000 MP4 plugin

Reply #15 –
New version in CVS now. This should make zZzZzZz happy

Menno

foobar2000 MP4 plugin

Reply #16 –
New version compiled and uploaded.

foobar2000 MP4 plugin

Reply #17 –
Quote
New version compiled and uploaded.

Thanks, its working ok.

Can i delete the dll that came with john33's compile (because it wasn't present in your zip file) ?

I must say i'm a bit confused now. 

foobar2000 MP4 plugin

Reply #18 –
Quote
Can i delete the dll that came with john33's compile (because it wasn't present in your zip file) ?

Yes, it's not needed with my compile. I use still good old MSVC6 and all libraries my compiles need are included in anything newer than Win95.

foobar2000 MP4 plugin

Reply #19 –
Link points now to version for 0.34.

foobar2000 MP4 plugin

Reply #20 –
Excellent work, it now plays my files perfectly!  I've been waiting forever for winamp to implement international functionality, but you guys had it beat so quickly.  Good job all. 

foobar2000 MP4 plugin

Reply #21 –
MP4 plugin now also supports tagging.

Menno

foobar2000 MP4 plugin

Reply #22 –
Binary for 0.35a uploaded.

foobar2000 MP4 plugin

Reply #23 –
who can make a wma plugin for fb2000?

foobar2000 MP4 plugin

Reply #24 –
Quote
MP4 plugin now also supports tagging.

Menno

Wow... B)  And what about us poor Winamp (l)users?
ZZee ya, Hans-Jürgen
BLUEZZ BASTARDZZ - "That lil' ol' ZZ Top cover band from Hamburg..."
INDIGO ROCKS - "Down home rockin' blues. Tasty as strudel."