Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: MP3Gain, major bug? (Read 4463 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

MP3Gain, major bug?

I just tried the latest beta 1.3.1/1.4.4 on a subset (3500 files) of my music library after reading various recommendations.

All of my files have correct tags and the file names are all of the
form:

"<track no> - <title>.mp3"

e.g. "01 - 8 Easy Steps.mp3"

or

"<track no> - <artist> - <title>.mp3"

for compilation albums.

I performed the steps in the help file section "Make every mp3 the same volume". It appears to have worked but all of my file names have been truncated like this:

26/09/2004  18:44      4,145,358  01-8EA~1.MP3
26/09/2004  18:44      3,692,878  02-OUT~1.MP3
26/09/2004  18:44      5,099,726  03-EXC~1.MP3
26/09/2004  18:44      3,858,638  04-DOT~1.MP3
26/09/2004  18:44      5,306,574  05-KNE~1.MP3
26/09/2004  18:44      7,295,182  06-SO-~1.MP3
26/09/2004  18:44      5,718,222  07-NOT~1.MP3
26/09/2004  18:44      7,391,438  08-THI~1.MP3
26/09/2004  18:44      6,140,110  09-SPI~1.MP3
26/09/2004  18:44      6,633,678  10-EVE~1.MP3

Have I missed a step or an option somewhere or is this a major bug?

Why does the program even touch the file names at all?

MP3Gain, major bug?

Reply #1 –
Quote
I just tried the latest beta 1.3.1/1.4.4 on a subset (3500 files) of my music library after reading various recommendations.

All of my files have correct tags and the file names are all of the
form:

"<track no> - <title>.mp3"

I performed the steps in the help file section "Make every mp3 the same volume". It appears to have worked but all of my file names have been truncated like this:

26/09/2004  18:44       4,145,358  01-8EA~1.MP3

Have I missed a step or an option somewhere or is this a major bug?

Why does the program even touch the file names at all?
[{POST_SNAPBACK}][/a]


Argh. It's a bug, sorry. If you don't need Unicode support, then download version 1.2.3(/1.3.3) instead. If you don't know whether or not you "need Unicode support", then you probably don't need it
Version 1.2.3 is the "stable" version listed on the downloads page:

[a href="http://mp3gain.sourceforge.net/download.php]http://mp3gain.sourceforge.net/download.php[/url]


In the meantime, I'd like to get this issue straightened out. What version of Windows are you using? Also, please post here the complete path on your hard drive to one of the files that got re-named. For example, something like:

C:\MP3s\Mp3Gain test\The House Jacks\Drive\01 - Feelin Funkae.mp3


For anyone interested, the problem here is that the GUI has problems passing the full unicode file names to the back end. So instead, it passes the old 8.3 character "short" file name. I tested this out on my machine as thoroughly as I thought I could, and it didn't cause problems. But apparently in some cases it makes the short file name replace the full file name.

-Glen

MP3Gain, major bug?

Reply #2 –
No worries, thankfully these files are just a backup of what I have on my iRiver so no harm done.

I am using XP Pro, SP2.

Here's a typical song name:

"C:\Documents and Settings\Mark Briody\My Documents\My Synched Music\Alanis Morissette\So-called Chaos\01 - 8 easy steps.mp3"

Is the length of the directory path causing the problem?

Mark

By the way, if you need a guinea pig I'm happy to beta test any fix.

MP3Gain, major bug?

Reply #3 –
Quote
Here's a typical song name:

"C:\Documents and Settings\Mark Briody\My Documents\My Synched Music\Alanis Morissette\So-called Chaos\01 - 8 easy steps.mp3"

Is the length of the directory path causing the problem?


Don't know yet. I'm trying to recreate the problem here.

EDIT: Nope. Not just the path length. I made a file with precisely the same path and had no problem. Going to keep experimenting.
(end edit)

Worst-case scenario (which isn't too bad), I'll have the GUI double-check the file name after each file-modifying call to the back end. That shouldn't slow things down enough for anyone to notice.
But I'd prefer to figure out precisely how to prevent the problem in the first place.

-Glen

MP3Gain, major bug?

Reply #4 –
Quote
Worst-case scenario (which isn't too bad), I'll have the GUI double-check the file name after each file-modifying call to the back end.


And that's what I just did.

Mark, try out this version of the GUI:

http://mp3gain.sourceforge.net/mp3gaingui132.zip

After each action that could potentially change the file name, it does a quick check to make sure the full file name hasn't changed. If it has, then it just changes it back.

If it works for you and works for me, then I'll release it as the latest Beta.

-Glen

MP3Gain, major bug?

Reply #5 –
After renaming my mp3's I just re-ran the original app and now it isn't showing the bug.

I'll have to restore the original, untouched, files from my iRiver  MP3 player and try again until the bug is repeatable. Otherwise I won't be able to tell if you've fixed it.

Quote
Quote
Worst-case scenario (which isn't too bad), I'll have the GUI double-check the file name after each file-modifying call to the back end.


And that's what I just did.

Mark, try out this version of the GUI:

http://mp3gain.sourceforge.net/mp3gaingui132.zip

After each action that could potentially change the file name, it does a quick check to make sure the full file name hasn't changed. If it has, then it just changes it back.

If it works for you and works for me, then I'll release it as the latest Beta.

-Glen
[a href="index.php?act=findpost&pid=244869"][{POST_SNAPBACK}][/a]

MP3Gain, major bug?

Reply #6 –
Quote
After renaming my mp3's I just re-ran the original app and now it isn't showing the bug.


  .....okay, now my mind is boggling.
If you can figure out exactly what happened the first time, that would be exceedingly useful.

-Glen

MP3Gain, major bug?

Reply #7 –
sorry for hijacking this thread, but i had a similiar problem with path/filenames today..

i was trying to albumgain this file:
K:\_ungained\DVD#17\Fury in the Slaughterhouse\Fury in the Slaughterhouse - 1997 - Brilliant Thieves [Bonus-CD]\Fury in the Slaughterhouse - 1997 - Brilliant Thieves [Bonus-CD] - 10 - Out on the Weekend (Jens Krause und das Wunder der Stereophonie Mix).mp3

the analysis pass worked fine, but when it tried to gain this file, it aborted with an error: can't write to file. first i thought the file was corrupt, but fixing it with several tools in several different ways, removing the tags, etc. didn't change anything. i really didn't know what to do anymore.

then i searched here for another way to fix mp3s as i discovered this thread, and i thought maybe it has something to do with the filename. i copied the mp3 to another folder, and it worked fine there. so i knew the long path/filename was to blame. as it turns out, the path+filename is exactly 256 characters long. if i remove only one character from the filename or the path, everything works fine. if that isn't bad luck, you tell me what bad luck is!

but on the other hand i wouldn't have found this bug in mp3gain, so maybe it had something good too. 

MP3Gain, major bug?

Reply #8 –
Quote
sorry for hijacking this thread, but i had a similiar problem with path/filenames today..


I think I'm going to cry 

No, not really, but it's driving me crazy that I can't recreate these problems on my own machine.

Thana, is the problem consistent? I mean if you repeatedly change the file name from the "bad" 256-character version to a "good" version and back again, does the problem keep going away and coming back again?

-Glen